Fix wrong color in text inputs #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
review-needed
ABA-602 Wrong color on text inputs
They are now always |
eikhr
approved these changes
Oct 12, 2023
Also fix wrong styling on prefix icon given by the recent changes to the Icon component.
ivarnakken
force-pushed
the
input-field-color
branch
from
b6214b9
to
5bc4632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also fix wrong styling on prefix icon given by the recent changes to the Icon component.
Result
Testing
I have thoroughly tested my changes.
Text inputs now have a correct text color.
Tested with and without a
prefix, andcenteredinputs.prefixstill works as expected, by focusing on the input when clicked.Resolves ABA-602