Fix and use the description on fields
#4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
review-needed
ABA-494 Move tooltips on event editor to the side of the input field
Kind of annoying that all the fields here have a tooltip. A lot of the time it is not interesting since it has already been read. Instead, there should be an info icon or something (kind of like on the poll overview component) at the side. |
norbye
requested changes
Oct 14, 2023
ivarnakken
force-pushed
the
ivarnakken/aba-494-move-tooltips-on-event-editor-to-the-side-of-the-input-field
branch
from
a2abc2a
to
f7946f4
Compare
ivarnakken
force-pushed
the
ivarnakken/aba-494-move-tooltips-on-event-editor-to-the-side-of-the-input-field
branch
from
f7946f4
to
591b559
Compare
ivarnakken
added
approved
ivarnakken
changed the title
description on fields
ivarnakken
deleted the
ivarnakken/aba-494-move-tooltips-on-event-editor-to-the-side-of-the-input-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the description styling on fields
Refactor fields to use description prop
Result
The icons makes the page more "cluttered", but easier/better to use. It's a trade-off. Note that the event editor is the only page with a ton of field descriptions, so given that it's an anomaly I wouldn't say it's a big deal.
Testing
All fields still look as expected.