Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give input selectors a default placeholder #4190

Merged
merged 1 commit into from Oct 15, 2023
Merged

Give input selectors a default placeholder #4190

merged 1 commit into from Oct 15, 2023

Conversation

ivarnakken
Copy link
Member

Description

Much better than the default "Select..."

Result

Before After
image image

Testing

  • I have thoroughly tested my changes.

Specified placeholders still override, and it works with both inlineLabel and noLabel.

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review labels Oct 14, 2023
@ivarnakken ivarnakken requested a review from a team October 14, 2023 10:59
@ivarnakken ivarnakken self-assigned this Oct 14, 2023
@linear
Copy link

linear bot commented Oct 14, 2023

ABA-607 Set a default placeholder on input selectors

Based on the given label you can easily create a default placeholder.

@ivarnakken
Give input selectors a default placeholder
23b646a 
Much better than the default "Select..."
@ivarnakken ivarnakken force-pushed the ivarnakken/aba-607-set-a-default-placeholder-on-input-selectors branch from 424a6f1 to 23b646a Compare October 14, 2023 11:04
@ivarnakken ivarnakken added approved Pull requests that have been approved small-fix Pull requests that fix something small ready-to-merge Pull requests that have been approved and are ready to be merged labels Oct 15, 2023
@ivarnakken ivarnakken merged commit e56bedb into master Oct 15, 2023
4 checks passed
@ivarnakken ivarnakken deleted the ivarnakken/aba-607-set-a-default-placeholder-on-input-selectors branch October 15, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbye norbye norbye approved these changes

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features ready-to-merge Pull requests that have been approved and are ready to be merged review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
2 participants
@ivarnakken @norbye