Stop survey editor from crashing on certain surveys #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why questionType sometimes becomes undefined
ivarnakken
added
enhancement
/surveys still need a big retouch, but this is something.
ivarnakken
force-pushed
the
ivarnakken/aba-468-not-possible-to-edit-surveys
branch
from
45e61c0
to
7ee60cd
Compare
norbye
approved these changes
Oct 15, 2023
ivarnakken
deleted the
ivarnakken/aba-468-not-possible-to-edit-surveys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop survey editor from crashing on certain surveys
Not sure why questionType sometimes becomes undefined
Minor improvements to the survey editor
/surveys still need a big retouch, but this is something.
Result
A lot of very minor changes not really visible:
Testing
Editing the survey that previously crashed (e.g. /surveys/511/edit) now works 馃コ