Fix TextWithIcon icon alignment #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arashfa0301
requested review from
eikhr,
danielyanghansen,
falbru,
juniwbjerde and
Arashfa0301
ivarnakken
requested changes
Oct 16, 2023
| content, | ||
| tooltipContentIcon, | ||
| iconRight = false, | ||
| size, | ||
| }: Props) => { | ||
| return ( | ||
| <Flex alignItems="center" className={className}> |
There was a problem hiding this comment.
The className is used other places than on the event page, so the removal of this will break all of those. Any reason for removing?
There was a problem hiding this comment.
Not really. Added it back now.
ivarnakken
added
review-needed
Arashfa0301
approved these changes
Oct 16, 2023
ivarnakken
approved these changes
Oct 16, 2023
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed wrapping of TextWithIcon component, thus also fixing the alignment of icons. Did this by wrapping the content (the text) in a span, and adding a div wrapping the span with "width: max-content".
Result
before
after
Testing
Tested locally on both laptop, desktop and mobile views.