Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section-dividers and titles to event statistics #4203

Merged
merged 1 commit into from Oct 17, 2023
Merged

Add section-dividers and titles to event statistics #4203

merged 1 commit into from Oct 17, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 17, 2023 •
edited

Description

Add title and description to the two main sections of the event statistics to make it clearer what the different sections are based on.

Result

Before After
No signups image image
After signups image image

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

@norbye norbye requested a review from a team October 17, 2023 00:20
@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 17, 2023
ivarnakken
ivarnakken approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@norbye norbye added approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Oct 17, 2023
@norbye norbye merged commit cc2f3f0 into master Oct 17, 2023
4 checks passed
@norbye norbye deleted the event-statistics-titles branch October 17, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged
Projects
None yet
Milestone
No milestone
2 participants
@norbye @ivarnakken