Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default survey activation time to 14:30 #4211

Merged
merged 1 commit into from Oct 19, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Oct 18, 2023

Description

This was requested by the arranging komitees a few weeks ago to avoid conflicts with event registrations, which are usually on the hour. It sets default activation time to 14:30 the day after the event end time, or tomorrow at 14:30 if no event is selected.

Result

See how it says 14:30(the event is 23. Oct):
Screenshot 2023-10-18 at 15 03 49

Testing

  • I have thoroughly tested my changes.

Have tested both with and without a connected event, and with templates.

Resolves ABA-612

@linear
Copy link

linear bot commented Oct 18, 2023

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 18, 2023
@eikhr eikhr force-pushed the change-default-survey-activation-time branch from 4361de6 to 728f777 Compare October 18, 2023 13:08
Copy link
Contributor

@ollfkaih ollfkaih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change

Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ivarnakken ivarnakken added bug-fix Pull requests that fix a bug approved Pull requests that have been approved labels Oct 18, 2023
@eikhr eikhr merged commit 186f0a6 into master Oct 19, 2023
4 checks passed
@eikhr eikhr deleted the change-default-survey-activation-time branch October 19, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
4 participants