Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external links to nav menu #4212

Merged
merged 1 commit into from Oct 22, 2023
Merged

Add external links to nav menu #4212

merged 1 commit into from Oct 22, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 18, 2023

Description

Add a few highlighted external links to the nav menu, and a link to AbaBart where users can find the rest of them.

Result

Before

image

After

image

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ABA-614

@linear
Copy link

linear bot commented Oct 18, 2023

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 18, 2023
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features approved Pull requests that have been approved labels Oct 18, 2023
Copy link
Contributor

@itsisak itsisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@norbye norbye added do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged and removed review-needed Pull requests that need review labels Oct 19, 2023
@norbye norbye self-assigned this Oct 19, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 21, 2023
@norbye norbye removed review-needed Pull requests that need review do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged labels Oct 21, 2023
@norbye norbye enabled auto-merge October 21, 2023 05:02
@norbye norbye merged commit 291c783 into master Oct 22, 2023
4 checks passed
@norbye norbye deleted the menu-external-links branch October 22, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features
Projects
None yet
3 participants