Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flex from tooltip content #4230

Merged
merged 1 commit into from Oct 24, 2023
Merged

Remove flex from tooltip content #4230

merged 1 commit into from Oct 24, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 24, 2023

Description

Change Tooltip content styling from flex to block, so that content will behave as they are inline elements and not be adjusted by the flex styling.

Haven't searched that much - but within the places I found it made no difference that the align-items wasn't set (and it wont work without flex), so removed that as well.

Result

Before

image

After

image

The other tooltips I've visited (mainly the welcome page and the rest on the event detail page) behave the same before and after.

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ABA-609

@linear
Copy link

linear bot commented Oct 24, 2023

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 24, 2023
@norbye norbye added the bug-fix Pull requests that fix a bug label Oct 24, 2023
@norbye norbye merged commit 6dc99d5 into master Oct 24, 2023
4 checks passed
@norbye norbye deleted the tooltip-flexbug branch October 24, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
3 participants