Changed backgroundcolor for interested on bdb interestpage #4232
Conversation
app/routes/bdb/components/bdb.css
Outdated
| @@ -114,7 +114,7 @@ | |||
| } | |||
|
|
|||
| .interested { | |||
| background-color: #f5f5d5; | |||
| background-color: #B33939; | |||
There was a problem hiding this comment.
Can we use a variable instead?😄
There was a problem hiding this comment.
Can we use a variable instead?😄
We thought about it. If we only change .interested and not the other classes: interested will change color when we change between light/dark mode, but the others will stay same
There was a problem hiding this comment.
Can we use a variable instead?😄
We thought about it. If we only change .interested and not the other classes: interested will change color when we change between light/dark mode, but the others will stay same
one solution is to change multiple classes, but then the color at the page will be different and can maybe cause problems for bedroom
Should we still do it?
ShaileshS1702
added
types
app/styles/variables.css
Outdated
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| --lego-max-width: 1100px; | |||
| --lego-default-padding: 2rem; | |||
| --bdb-interested: #B33939; | |||
There was a problem hiding this comment.
I think I prefer to use existing colours rather than introducing new ones
There was a problem hiding this comment.
The question is then what is the best way:
If we do choose to use variables, the color will change with the lightning mode:
While in light mode "ikke interessert" is darker than "Interessert", in dark mode the opposite can be observed. While this may not be a big issue, if the user of the site remember states based on color, it may be difficult if they change lightning.
We can either go through with or we can use a different color over all. The reason we chose to use red was that we thought it was smart that states that are similar should also have similar color.
As we are new to this, we are of course open to suggestions, so what do you think we should do?
There was a problem hiding this comment.
@ivarnakken What's your opinion on adding color variables that don't change based on theme? It'd make the solution to issues such at these a lot easier.
There was a problem hiding this comment.
"Ikke interessert" should be the danger color. "Interessert" shouldn't really be red at all, but rather a yellow/orange like you suggest.
The colors here in the bdb were picked randomly by a webkomer many many years ago. Feel free to change.
ivarnakken
added
bug-fix
reason: problems with darkmode Co-authored-by: Magnus Brecke <magnus.brecke@gmail.com> Co-authored-by: Christian Thielemann Grytøyr <christian.grytoyr@ebnett.no>
ivarnakken
added
approved
reason: problems with darkmode
Resolves ... (either GitHub issue or Linear task)
ABA-615