Fix validation bug in CompanyEditor and improve types #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
requested review from
danielyanghansen,
juniwbjerde,
EliHaugu and
Lundis1
ABA-660 Fix bdb company add validation error
If website link is not defined the entire webpage becomes unresponsive |
eikhr
force-pushed
the
fix-bdb-add
branch
3 times, most recently
from
2089ed1
to
fc9b208
Compare
juniwbjerde
approved these changes
Nov 7, 2023
ivarnakken
approved these changes
Nov 7, 2023
ivarnakken
added
priority:high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CompanyEditor would freeze up if you attempted to submit with an invalid link. While fixing this I got a bit lost in the types 馃槄
Result
It no longer freezes, and instead gives correct feedback.
Testing
Resolves ABA-660