Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AppRoute and related components to use redux hooks #4348

Merged
merged 3 commits into from Nov 30, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Nov 28, 2023

Description

Refactor global app-components like <App> and <Header> to use hooks instead of connect and props. I think this makes the code more readable and hopefully easier to maintain.

Result

No visual changes.

Testing

  • I have thoroughly tested my changes.

Have tested a bit, with and without ssr. Stuff still works.

@github-actions github-actions bot added the review-needed Pull requests that need review label Nov 28, 2023
Copy link
Contributor

@ollfkaih ollfkaih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eikhr eikhr merged commit e30a75a into master Nov 30, 2023
4 checks passed
@eikhr eikhr deleted the refactor-approute branch November 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
2 participants