Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing month of date selector in cypress #4349

Merged
merged 1 commit into from Nov 30, 2023
Merged

Fix changing month of date selector in cypress #4349

merged 1 commit into from Nov 30, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Nov 30, 2023

Description

There was a small error in the selector, causing cypress to not find the arrow for selecting next month in the date selector. It only attempts to switch month on the last day each month, which is why it started failing now.
This one:
Screenshot 2023-11-30 at 16 44 52

Result

No more error!

Testing

  • I have thoroughly tested my changes.

If cypress works on this PR it means i fixed it:)

@eikhr eikhr added flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! bug-fix Pull requests that fix a bug labels Nov 30, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Nov 30, 2023
Copy link
Member

@juniwbjerde juniwbjerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we fixed this a while ago, but apperently not... Anyways, this looks good!

@eikhr eikhr merged commit bc88712 into master Nov 30, 2023
4 checks passed
@eikhr eikhr deleted the fix-cypress branch November 30, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! review-needed Pull requests that need review
Projects
None yet
2 participants