Refactor /users to support react-router v6
#4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styling changes, and removal of unnecessary stuff.
Also fix 2 bugs introduced by the recent refactor to `react-final-form`: - `submitSucceeded` would always be undefined, as we would previously get this through `redux-form`. - The way we listen to user fields (for zxcbn) did not work either.
Not sure why this was neglected.
Ideally it should be able to take in all button types, but I'm planning on refactoring this further later.
CheckBox's onChange function had a recent change
And make it support `react-router` v6!
Also type some related user actions.
ivarnakken
added
review-needed
ivarnakken
changed the title
ivarnakken
added
types
ivarnakken
changed the title
react-router v6
* Refactor user settings * Fix some bugs caused by undefined user objects * Improve some styling on some user pages (better layout and use of cards) * Improve some types * Clean up routing
ivarnakken
force-pushed
the
ivarnakken/aba-714-refactor-users-to-support-react-router-6
branch
from
f3682fb
to
48b19a8
Compare
ivarnakken
merged commit ef9e224
into
migrate-away-from-connected-router
2 checks passed
ivarnakken
deleted the
ivarnakken/aba-714-refactor-users-to-support-react-router-6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ended up refactoring a bunch of stuff, some minor stuff, some bigger stuff and some bugs.
Result
Actually some minor visual changes this time as well. I couldn't help myself.
Testing
I think I tested everything ...