Refactor /photos to support react-router v6
#4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And to a functional component. Also fix a bug where the initial values was not used?
Also refactor it to `react-final-form`.
Also fix misspelling bug (tile -> title) in its helmet property generator.
Also some minor styling changes.
Less props passed around!
Also fix the wrong url in its helmet property generator.
ivarnakken
added
review-needed
ivarnakken
changed the title
ivarnakken
changed the title
react-router v6
ivarnakken
added
types
ivarnakken
merged commit 56f6d72
into
migrate-away-from-connected-router
2 checks passed
ivarnakken
deleted the
ivarnakken/aba-698-refactor-photos-to-support-react-router-v6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor!
Some minor bugs were also squashed
Result
Not really any big visual changes.
Testing
All routes were kinda tested :)