Refactor /meetings to support react-router v6
#4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would compare usernames with user IDs. Replaced the pills with tags since it looks better and matches the author tag on comments. Expanded the Tag component to accept icon sizes, since the pencil icon looked off with the default sizing.
Also fix some ts types here and there
ivarnakken
added
enhancement
ivarnakken
changed the title
react-router v6
ivarnakken
merged commit 9080fc4
into
migrate-away-from-connected-router
2 checks passed
ivarnakken
deleted the
ivarnakken/aba-696-refactor-meetings-to-support-react-router-v6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor and refactor, and bug fix
Result
I couldn't help myself
Testing
All routes were tested, kinda
Resolves ABA-717