Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employ the correct SelectInput everywhere #4370

Conversation

ivarnakken
Copy link
Member

Description

A lot of components used the "wrong" select input instead of the wrapper
component with the correct styling and functionality.


Also, fix the tooltip by not showing it if it is disabled.

Result

Before After
image image

Testing

  • I have thoroughly tested my changes.

Select inputs were tested and still work.

@ivarnakken ivarnakken added review-needed Pull requests that need review bug-fix Pull requests that fix a bug labels Dec 14, 2023
@ivarnakken ivarnakken requested a review from a team December 14, 2023 14:26
@ivarnakken ivarnakken self-assigned this Dec 14, 2023
Copy link

linear bot commented Dec 14, 2023

A lot of components used the "wrong" select input instead of the wrapper
component with the correct styling and functionality.
@ivarnakken ivarnakken force-pushed the ivarnakken/aba-557-make-the-dropdown-menu-under-grupper-have-a-dark-theme branch from c2f2750 to c0c8998 Compare December 14, 2023 16:59
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Dec 23, 2023
@ivarnakken ivarnakken merged commit 7f7c9dc into master Dec 23, 2023
4 checks passed
@ivarnakken ivarnakken deleted the ivarnakken/aba-557-make-the-dropdown-menu-under-grupper-have-a-dark-theme branch December 23, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
3 participants