Refactor /bdb to support react-router v6
#4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
types
ivarnakken
added
the
enhancement
ivarnakken
force-pushed
the
ivarnakken/aba-693-refactor-bdb-to-support-react-router-v6
branch
2 times, most recently
from
20d3f41
to
0a64eab
Compare
The initial values of the form was ignored for some reason? Fixed here `ImageUploadField` was also refactored.
This 'important' validation check had been forgotten. Made it all look nicer with some cards.
The initial values were not used here as well ...
ivarnakken
force-pushed
the
ivarnakken/aba-693-refactor-bdb-to-support-react-router-v6
branch
from
0a64eab
to
47991b1
Compare
ivarnakken
force-pushed
the
ivarnakken/aba-693-refactor-bdb-to-support-react-router-v6
branch
from
47991b1
to
48eeddd
Compare
ivarnakken
merged commit 7071212
into
migrate-away-from-connected-router
2 checks passed
ivarnakken
deleted the
ivarnakken/aba-693-refactor-bdb-to-support-react-router-v6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor, refactor, bug fix, refactor
/bdb still has a lot of improvements to be made ..
Result
Some minor visual changes - see if you can spot them
Testing
Kinda