-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final steps in the react-router
v6 migration! 馃帀
#4377
Final steps in the react-router
v6 migration! 馃帀
#4377
Commits on Dec 25, 2023
-
It is not compatible with `react-router` v6.4, and is not something we "really" need.
Configuration menu - View commit details
-
Copy full SHA for e72f5c5 - Browse repository at this point
Copy the full SHA e72f5c5View commit details
Commits on Dec 26, 2023
-
Remove compatability package and bump
react-router
to v6All uses of `useHistory` had to be replaced with `useNavigate`.
Configuration menu - View commit details
-
Copy full SHA for b466a98 - Browse repository at this point
Copy the full SHA b466a98View commit details -
`react-router` v6 does not allow context to be passed as a prop to `StaticRouter`, so a simple workaround was to just create our own React Context.
Configuration menu - View commit details
-
Copy full SHA for deb4a81 - Browse repository at this point
Copy the full SHA deb4a81View commit details -
Make lego-bricks compatible with webapp's upgraded router
Also remove a bunch of stub @types packages. Some are already provided in the packages themselves, and the `react-router` specific ones caused some compatability issues for some reason. And fix a small ts error in the ConfirmModal code preventing build to complete.
Configuration menu - View commit details
-
Copy full SHA for 7028a69 - Browse repository at this point
Copy the full SHA 7028a69View commit details
Commits on Jan 8, 2024
-
I've noticed several issues with running `react-router` v6 on `node` v16. It was about time anyways .. For some reason I now had to update some stylelint stuff?
Configuration menu - View commit details
-
Copy full SHA for bdf769d - Browse repository at this point
Copy the full SHA bdf769dView commit details
Commits on Jan 9, 2024
-
The tests relied on passing props into the page components, but this is no longer accepted. Nevertheless, what they try to test is already tested in our e2e tests, and besides it's quite uncommon to unit test entire pages.
Configuration menu - View commit details
-
Copy full SHA for 9d73130 - Browse repository at this point
Copy the full SHA 9d73130View commit details
Commits on Jan 11, 2024
-
Fix various bugs in the event editor
* Issues with a default pool not appearing when picking an appropriate event status type * Pool merge time was being validated when it was not supposed to * useMazemap would always be true, even when a normal location had been set * Not actually in the editor, but it was previously not possible to view registrations on the event detail page because of the wrong check for `hasFullAccess` * Better (and accurate) validation
Configuration menu - View commit details
-
Copy full SHA for 7724624 - Browse repository at this point
Copy the full SHA 7724624View commit details -
Fix various e2e tests related to the
react-router
migrationAmong other things, `SubmitButton` now accepts a `disabled` prop in case you want to check for more things.
Configuration menu - View commit details
-
Copy full SHA for 48b481f - Browse repository at this point
Copy the full SHA 48b481fView commit details -
Prevent infinite fetching on /meetings
When the user had no prior meetings, `meetingSections.length` would always be `0`, leading to an endless loop of fetching. Fixed by introducing a simple flag.
Configuration menu - View commit details
-
Copy full SHA for 5a90bae - Browse repository at this point
Copy the full SHA 5a90baeView commit details -
Prevent infinite fetching on /events
Not sure why `pagination` was added to the dependency array, but nevertheless this caused an endless loop of fetching. The "fetch more" button seemed to not work without some proper feedback, so I added that as well.
Configuration menu - View commit details
-
Copy full SHA for e787d12 - Browse repository at this point
Copy the full SHA e787d12View commit details -
Fix issue with fetching quotes on the approve page
The query should be in the dependency array to force a fetch when switching the page (the query).
Configuration menu - View commit details
-
Copy full SHA for a6d6313 - Browse repository at this point
Copy the full SHA a6d6313View commit details -
Configuration menu - View commit details
-
Copy full SHA for e54efdd - Browse repository at this point
Copy the full SHA e54efddView commit details -
Handle query params in navigation link better
Extend the NavLink wrapper to accept a list of paths to "accept".
Configuration menu - View commit details
-
Copy full SHA for cd6de5d - Browse repository at this point
Copy the full SHA cd6de5dView commit details -
Fix issue with fetching memberships on both /admin and /pages
I believe the core of the issue was the spread operator for the query in the fetch action, but I'm too tired to look into exactly why that was.
Configuration menu - View commit details
-
Copy full SHA for 3c9505d - Browse repository at this point
Copy the full SHA 3c9505dView commit details -
All fields were disabled when creating a new restricted mail because the `isNew` check was wrong. Unlike for the forms for email lists and users, the url param here will not be `new` but rather `undefined`.
Configuration menu - View commit details
-
Copy full SHA for a5faade - Browse repository at this point
Copy the full SHA a5faadeView commit details -
Fix bad pagination on both public and bdb company detail
`endpoint` would be `undefined`, and a bad API request would be made.
Configuration menu - View commit details
-
Copy full SHA for 10e8e98 - Browse repository at this point
Copy the full SHA 10e8e98View commit details