Resolve some router-v6 bugs #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undefined objects for non-authorized users. Missing location invocations.
norbye
added
review-needed
ivarnakken
approved these changes
Jan 14, 2024
|
No worries:) uncovered another issue I haven't fixed just yet - but detailed it in linear. And forgot to mention in the text description that after your PRs, the board,committee,etc. pages were visible to non-authenticated members - and now they are not. |
norbye
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undefined objects for non-authorized users.
Missing location invocations.
Result
Now it doesn't crash for those specific issues.
Testing
Went through the webapp in most routes as both authenticated and non-authenticated user. Now these two issues appear to be resolved.
Resolves ABA-737