Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show confetti after registering a user #4399

Merged
merged 2 commits into from Jan 23, 2024
Merged

Show confetti after registering a user #4399

merged 2 commits into from Jan 23, 2024

Conversation

ivarnakken
Copy link
Member

Description

Thought this was kinda fun

Also fix a bug :)

Result

Screen.Recording.2024-01-18.at.18.00.08.mov

Testing

  • I have thoroughly tested my changes.

The confetti works?

This resolves nothing. Not needed at all.

@ivarnakken
Validate correct token in user confirmation
75036e2 
`loadData` was not properly ran.
@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features dependencies Pull requests that update a dependency file review-needed Pull requests that need review bug-fix Pull requests that fix a bug labels Jan 18, 2024
@ivarnakken ivarnakken requested a review from a team January 18, 2024 17:02
@ivarnakken ivarnakken self-assigned this Jan 18, 2024
falbru
falbru approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A must-have feature 😎

Bestem0r
Bestem0r approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Jan 18, 2024
@ivarnakken
Show confetti after registering a user
c544cc3 
Thought it was kinda fun
@ivarnakken ivarnakken merged commit dd7f6af into master Jan 23, 2024
4 checks passed
@ivarnakken ivarnakken deleted the confetti branch January 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bestem0r Bestem0r Bestem0r approved these changes

@falbru falbru falbru approved these changes

@jonasdeluna jonasdeluna jonasdeluna approved these changes

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug dependencies Pull requests that update a dependency file enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
4 participants
@ivarnakken @Bestem0r @falbru @jonasdeluna