Fix bug where search was performed on undefined string causing crash

[norbye]

Description

The check was for null values, but after the refactor the value was set to undefined - which is correct typewise, but fucked up the search function.
Removed the null-value check as a null-value should not be allowed with the current type (string | undefined).

Result

No crash

Testing

• I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

---

Resolves ABA-746

[linear]

ABA-746 Fix opening reaction picker modal crashes the page bug

[ivarnakken]

Hahah this was driving me nuts! Thanks for just fixing❤️

[ivarnakken]

@norbye
Have you looked at the code in ReactionPickerContent.tsx as well? Shouldn't the type and the two checks be wrong here as well now?
EDIT: I now see that the useMemo returns null, so this is actually correct. I misread.

But, this check in ReactionPicker.tsx seems wrong, no?

[norbye]

@norbye Have you looked at the code in ReactionPickerContent.tsx as well? Shouldn't the type and the two checks be wrong here as well now? EDIT: I now see that the useMemo returns null, so this is actually correct. I misread.

ReactionPickerContent.tsx doesn't have access to searchString, so that should be good - at least from any changes in this PR.

But, this check in ReactionPicker.tsx seems wrong, no?

You're absolutely right, will fix:) while we're on it, it always checks for both undefined and empty string, so I might as well just set it to default to an empty string and as such the type won't allow undefined.

Would've been so nice if the linter picked up comparisons between invalid values