Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of interestgroup page #4408

Merged
merged 2 commits into from Jan 24, 2024
Merged

Conversation

itsisak
Copy link
Contributor

@itsisak itsisak commented Jan 23, 2024

Description

Quick fix to make the page look prettier. Took inspiration from the joblistings page. The hover effect especially is the same.

Result

If you've made visual changes, please include before and after images, preferably with a description. Make sure they do not contain any real user information.

before

Screen.Recording.2024-01-23.at.10.37.07.mov

after
(Note: not all logos is actually the same, this is just for demonstration purposes since very few would load)

Screen.Recording.2024-01-23.at.10.39.42.mov

Testing

  • I have thoroughly tested my changes.

Resolves ABA-246

@itsisak itsisak added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review small-fix Pull requests that fix something small technical-debt Pull requests that reduces technical debt labels Jan 23, 2024
@itsisak itsisak self-assigned this Jan 23, 2024
Copy link

linear bot commented Jan 23, 2024

Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This has been looking crap for way too long(: Love the visual stuff and had some quick knitpicks on the code - although mostly stuff that was there before you started editing

Have you tested to see how the changes look in light mode?

app/routes/interestgroups/components/InterestGroupList.tsx Outdated Show resolved Hide resolved
app/routes/interestgroups/components/InterestGroupList.tsx Outdated Show resolved Hide resolved
app/routes/interestgroups/components/InterestGroupList.tsx Outdated Show resolved Hide resolved
app/routes/interestgroups/components/InterestGroupList.tsx Outdated Show resolved Hide resolved
app/routes/interestgroups/components/InterestGroup.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks A LOT cleaner. Good job 🔥

@itsisak
Copy link
Contributor Author

itsisak commented Jan 23, 2024

@norbye Lightmode and mobileview. Now also with abakus icon as alternate image.

lightmode

Screen.Recording.2024-01-23.at.13.00.35.mov

mobileview

Screen.Recording.2024-01-23.at.13.01.58.mov

@itsisak itsisak removed the review-needed Pull requests that need review label Jan 23, 2024
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! Thansk! 🏅

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Jan 23, 2024
@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 23, 2024
@itsisak itsisak removed the review-needed Pull requests that need review label Jan 24, 2024
@itsisak itsisak merged commit 00a2861 into master Jan 24, 2024
4 checks passed
@itsisak itsisak deleted the prettier-interestgroups branch January 24, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features small-fix Pull requests that fix something small technical-debt Pull requests that reduces technical debt
Projects
None yet
4 participants