Configure filtering to support multiselect #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
norbye
added
enhancement
norbye
force-pushed
the
multiselect-filter
branch
from
7c7067e
to
bf67b97
Compare
ivarnakken
added
types
ivarnakken
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement PR for #4257, which is now obsolete.
Add a
filterOptionsattribute to columns, where they can be set to allow selecting multiple elements in the filter.All filters are handled as arrays to simplify the divide between the two functionalities.
It wasn't possible to de-select radio-items by clicking them again, so I changed that.
If you're testing this locally, note that webkom/lego#3518 might not be in prod/staging yet - and if it isn't you need to run the backend locally to verify that it works for membership lists in groups.
Result
filterOptions.multiSelect: trueBefore
Skjermopptak.2024-01-27.kl.18.51.44.mov
After
Skjermopptak.2024-01-27.kl.18.51.08.mov
filterOptions.multiSelect: false | undefinedBefore
Skjermopptak.2024-01-27.kl.18.52.38.mov
After
Skjermopptak.2024-01-27.kl.18.52.59.mov
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-366