Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group table being cleared after adding a new member #4412

Merged
merged 1 commit into from Feb 2, 2024

Conversation

falbru
Copy link
Contributor

@falbru falbru commented Jan 28, 2024

Description

A bug was recently implemented where the table over all the members of a group under /admin/groups would be cleared after adding a new member. Only a hard refresh could fix that problem. This has now been fixed.

Result

before
Screencast from 2024-01-28 14-59-34.webm

after
Screencast from 2024-01-28 15-00-52.webm

Testing

  • I have thoroughly tested my changes.

Resolves ABA-751

@falbru falbru added review-needed Pull requests that need review bug-fix Pull requests that fix a bug labels Jan 28, 2024
Copy link

linear bot commented Jan 28, 2024

@falbru falbru requested a review from a team January 28, 2024 14:11
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetching the memberships again is kinda overkill but this is still a fix 🤷🏼‍♂️
I believe there's an issue with the selector

@falbru falbru merged commit 6b151d6 into master Feb 2, 2024
4 checks passed
@falbru falbru deleted the fix-add-user-to-group branch February 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
2 participants