Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding-left to header #4414

Merged
merged 1 commit into from Jan 29, 2024
Merged

Add padding-left to header #4414

merged 1 commit into from Jan 29, 2024

Conversation

norbye
Copy link
Member

@norbye norbye commented Jan 29, 2024

Description

Resolve issue with screens between 940px and 1040px where the logo would not have any padding to the side of the screen

This lack of padding has been bugging me for a while so lets get it outta here

Result

The logo is now indented by 20px on the left for big screens - which means it is flush with the events under instead of being 20px to the left

Before After
Width about 1000px image image
Wider screens image image
Smol screen No changes

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ... (either GitHub issue or Linear task)

Resolve issue with screens between 940px and 1040px where the logo would not have any padding to the side of the screen
@norbye norbye added the review-needed Pull requests that need review label Jan 29, 2024
@norbye norbye added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Jan 29, 2024
@norbye norbye merged commit 4192203 into master Jan 29, 2024
4 checks passed
@norbye norbye deleted the header-padding branch January 29, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved
Projects
None yet
2 participants