Catch inviting groups you can't access members of #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
approved these changes
Jan 31, 2024
Comment on lines
149
to
156
| .catch(() => { | ||
| // User has no permission to load group members | ||
| setFetchedGroupIds((prevIds) => [...prevIds, groupId]); | ||
| }); |
There was a problem hiding this comment.
Should this be .finally()? It seems like that's what you "actually" want since you're not checking the error
There was a problem hiding this comment.
Hmm it's a fair point.. the reason I put it in the catch clause is that I didn't want the 403 to pop up in the console as it's sort of expected behavior. But with the finally it would still show.
I guess it might be better to ignore 403 but throw all other errors tho - as that's the only expected one.
Open to other suggestions to solve the problem if you have any
Fixes LEGO-WEBAPP-1MP
norbye
force-pushed
the
meeting-invite-bug
branch
from
61b2ffc
to
bdae82d
Compare
ivarnakken
approved these changes
Feb 1, 2024
norbye
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature that preloads users to allow them to be used as secretary before creating the meeting is beautiful with sudo permissions, but it crashes the page with a 403 error if you want to invite a group you don't have permission to load the members of (typically a group you're not part of)
Result
Works on staging after demoting myself. Now the little popup on the bottom left of the screen appears to inform the user that the members were not loaded, but that's all. If you invite some groups you're a member of and some you're not the functionality is still intact for the groups you have permission to access.
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-772