Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize a success color #4425

Merged
merged 1 commit into from Feb 2, 2024
Merged

Standardize a success color #4425

merged 1 commit into from Feb 2, 2024

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Feb 1, 2024 •
edited

Description

This gives for a slightly better look on dark theme.

Result

Description Before After
A slightly different color on dark theme.

Testing

  • I have thoroughly tested my changes.

Works on both light and dark theme. This should not break anything else - even updated both duplicate variable files.

@ivarnakken ivarnakken added review-needed Pull requests that need review chore Pull requests that does something "boring", yet important, e.g. cleaning up code labels Feb 1, 2024
@ivarnakken ivarnakken requested a review from a team February 1, 2024 18:03
@ivarnakken ivarnakken self-assigned this Feb 1, 2024
@linear Linear
Copy link

linear bot commented Feb 1, 2024

ABA-783 Standardize a success color

@ivarnakken ivarnakken added the small-fix Pull requests that fix something small label Feb 1, 2024
@ivarnakken ivarnakken mentioned this pull request Feb 1, 2024
Open
1 task
norbye
norbye approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet - me likey

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Feb 2, 2024
itsisak
itsisak approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@itsisak itsisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@ivarnakken ivarnakken merged commit b039423 into master Feb 2, 2024
4 checks passed
@ivarnakken ivarnakken deleted the ivarnakken/aba-783-standardize-a-success-color branch February 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbye norbye norbye approved these changes

@itsisak itsisak itsisak approved these changes

@falbru falbru falbru approved these changes

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved chore Pull requests that does something "boring", yet important, e.g. cleaning up code review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
4 participants
@ivarnakken @norbye @itsisak @falbru