Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner #4426

Merged
merged 3 commits into from Feb 1, 2024
Merged

Banner #4426

merged 3 commits into from Feb 1, 2024

Conversation

ShaileshS1702
Copy link
Contributor

@ShaileshS1702 ShaileshS1702 commented Feb 1, 2024

Description

With "kommunikasjonsteknologi og cybersikkerhet"'s newest name change the banner had to be updated,

Result

If you've made visual changes, please include before and after images, preferably with a description. Make sure they do not contain any real user information.

![1f05e281e23936a0dfc8](https://github.co
om-abakus-banner-dark-mode
m/webkom/lego-webapp/assets/102583541/b90066bd-6669-4d53-af3f-9a139d2629d3)

Testing

  • I have thoroughly tested my changes.

I ran lego-webapp in staging and it looked good.


Resolves ... (either GitHub issue or Linear task)

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 1, 2024
@ivarnakken
Copy link
Member

Why is only the dark mode version transparent 🙃

Copy link
Contributor

@magnusbrecke magnusbrecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the picture size of the added picture be of the same dimensions as the deleted ones?

@ShaileshS1702
Copy link
Contributor Author

ShaileshS1702 commented Feb 1, 2024

Why is only the dark mode version transparent 🙃

The old ones was like that and thought we should do anything

Do you have any thoughts on the reply over

@ivarnakken
Copy link
Member

Remember to fill out everything in the pull request description
image

Copy link
Contributor

@magnusbrecke magnusbrecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@ShaileshS1702 ShaileshS1702 merged commit 6ba3b2d into master Feb 1, 2024
4 checks passed
@ShaileshS1702 ShaileshS1702 deleted the banner branch February 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
3 participants