Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show user registration feedback when relevant #4427

Merged
merged 2 commits into from Feb 2, 2024

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Feb 1, 2024

Description

It takes up unecessary space in an already crowded table

Result

Before After
image image

Testing

  • I have thoroughly tested my changes.

All empty feedbacks are still shown if feedback is required (which technically will only happen if there are no registrations).


Resolves ABA-784

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review labels Feb 1, 2024
@ivarnakken ivarnakken requested a review from a team February 1, 2024 19:33
@ivarnakken ivarnakken self-assigned this Feb 1, 2024
Copy link

linear bot commented Feb 1, 2024

Also, center unregister icon and remove the big gap between icons.
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stonks

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Feb 2, 2024
Copy link
Contributor

@itsisak itsisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@ivarnakken ivarnakken merged commit db06ca4 into master Feb 2, 2024
4 checks passed
@ivarnakken ivarnakken deleted the administrate-event-feedback branch February 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review
Projects
None yet
4 participants