New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google calender button for meetings #4437
Add google calender button for meetings #4437
Conversation
Hi! 👋 Thanks a lot for contributing! Although this is very useful in itself, it is actually something we already support. If you navigate to https://abakus.no/events and scroll all the way down (see image below) you are able to add both meetings and events to your calendar of liking. However, I can see how this feature is quite hidden from the user, so perhaps we can add these links to the meeting page as well? I think that would be super useful In my opinion, the current "implementation" is more robust and "ideal" as it will automatically sync everything, so the user does not have to manually add every meeting to the calendar. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks mostly good, but let's figure out what we want before doing anything 😄
title={meeting.title} | ||
startTime={meeting.startTime} | ||
endTime={meeting.endTime} | ||
description={meeting.description} | ||
location={meeting.location} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's easier to only pass the meeting
object as the prop and then destruct it in the AddToCalender
component
title={meeting.title} | |
startTime={meeting.startTime} | |
endTime={meeting.endTime} | |
description={meeting.description} | |
location={meeting.location} | |
meeting={meeting} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes, is there a common ancestor for meetings and events? The idea was for it to be easily utilized in other scenarios aswell
target="_blank" | ||
rel="noopener noreferrer" | ||
> | ||
<Button ghost>Legg til i Google Calender</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be a nerd, but it's actually written Google Calendar 🤓👆
}; | ||
|
||
return ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the <div>
needed?
I like it! In my opinion there is no harm in implementing both the calendar sync and add a single event to calendar - as they might cater to different wishes. And actually placing it inside the meeting details as Nils does is a genius move as that is where you are when you think of your meetings. Proposed idea of the next iteration for this; We can create a toggle, like MazeMap on the event pages, with something like "Legg til i kalender", which would open a section where the user can
This way it is in a much more visible place than it is right now, without taking up too much space and giving the possibility to explain the different options |
I can make a draft for the toggle idea, and you guys can discuss it later if you decide it is appropriate:)) |
Co-authored-by: Ivar Nakken <69514187+ivarnakken@users.noreply.github.com>
Co-authored-by: Ivar Nakken <69514187+ivarnakken@users.noreply.github.com>
Co-authored-by: Ivar Nakken <69514187+ivarnakken@users.noreply.github.com>
Great job! 🔥 Although we already have a similar feature implemented, this is a very good reminder that it's too hidden for the average user. Moving it to the meeting view like you've done is a very good idea! If you could implement something similar to what @norbye proposed, that would be awesome! |
I added a proposal for the toggle, I don't know the backend though and it seems like the current calendar options utelize the backend so I could not implement the other options. I can take a look at it when there is less school 😅 |
0b938a2
to
e8f0283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Just some nitpick hehe
e8f0283
to
e197e94
Compare
I would expect nothing else 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nilsvselte I don't think you have permission to give approving reviews on this on github, but as it is your PR I'd love to hear it if you have any thoughts about the changes before I merge and deploy it:) |
No, it looks great:) Learned a lot, thank you ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Ran it through our CI now - no errors! 🎉 I will merge this and deploy it by the end of the day Awesome job! Thanks again for contributing! 😄 |
Description
Knapp på møter for å legge til møtet i Google Calender
Result
Knapp
Testing
Hadde bare muligheten til å teste med møter jeg selv er en del av, fungerer dog feilfritt med disse.
Løser
Frustrasjon over at det ikke var en knapp der.