Update table component's skeleton look #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
ivarnakken
force-pushed
the
ivarnakken/aba-791-extend-table-component-with-a-skeleton-prop
branch
from
59df0ce
to
35305ea
Compare
Not only does it now resemble the other skeleton components, but it now also actually works
ivarnakken
force-pushed
the
ivarnakken/aba-791-extend-table-component-with-a-skeleton-prop
branch
from
35305ea
to
51b7fa5
Compare
norbye
approved these changes
Feb 10, 2024
| @@ -16,8 +16,30 @@ | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .loader { | |||
| height: 40.797px; | |||
There was a problem hiding this comment.
Rocket science happening right here
ivarnakken
deleted the
ivarnakken/aba-791-extend-table-component-with-a-skeleton-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not only does it now resemble the other skeleton components, but it now also actually works
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Screen.Recording.2024-02-10.at.12.24.10.mov
Screen.Recording.2024-02-10.at.12.22.02.mov
Testing
Tested that table does not show skeleton when not needed.