Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly reject promises on server #4464

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Properly reject promises on server #4464

merged 2 commits into from
Feb 16, 2024

Commits on Feb 15, 2024

  1. Properly reject promises on server 

    `Promise.resolve()` will not reject upon any of the input promises
rejecting, which can cause promises to never stop on the client if the
server sends unhandled promises. Simply replacing with a `Promise.all()`
fixes this issue.

Also clean up som effects so that only "valid" promises are made.
    @ivarnakken
    ivarnakken committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a6b017d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Replace Promise.all() in prepared side effects with .allSettled()

    @ivarnakken
    ivarnakken committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    f6a8b88 View commit details
    Browse the repository at this point in the history