Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revybanner #4467

Merged
merged 1 commit into from Feb 15, 2024
Merged

Add revybanner #4467

merged 1 commit into from Feb 15, 2024

Conversation

jennymul
Copy link
Contributor

Description

Add banner to promote Abakusrevyen.

Result

Screenshot from 2024-02-15 19-51-29

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Description Before After
... ... ...

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves ... (either GitHub issue or Linear task)

@jennymul jennymul added the review-needed Pull requests that need review label Feb 15, 2024
@jennymul jennymul self-assigned this Feb 15, 2024
christiangryt
christiangryt approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@christiangryt christiangryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

itsisak
itsisak approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@itsisak itsisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

Bestem0r
Bestem0r approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

ivarnakken
ivarnakken reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to also update the banner when you are not logged in. I know it's dumb but we have two different ones he he

@ivarnakken ivarnakken added approved Pull requests that have been approved changes-requested Pull requests with requested changes labels Feb 15, 2024
falbru
falbru approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@ivarnakken ivarnakken added chore Pull requests that does something "boring", yet important, e.g. cleaning up code and removed review-needed Pull requests that need review changes-requested Pull requests with requested changes labels Feb 15, 2024
@jennymul jennymul merged commit f874ceb into master Feb 15, 2024
4 checks passed
@jennymul jennymul deleted the revybanner branch February 15, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bestem0r Bestem0r Bestem0r approved these changes

@itsisak itsisak itsisak approved these changes

@falbru falbru falbru approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@christiangryt christiangryt christiangryt approved these changes

@Lundis1 Lundis1 Awaiting requested review from Lundis1

Assignees

@jennymul jennymul

Labels
approved Pull requests that have been approved chore Pull requests that does something "boring", yet important, e.g. cleaning up code
Projects
None yet
Milestone
No milestone
6 participants
@jennymul @Bestem0r @itsisak @falbru @ivarnakken @christiangryt