Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintended disabled email list field #4469

Merged
merged 1 commit into from Feb 19, 2024
Merged

Fix unintended disabled email list field #4469

merged 1 commit into from Feb 19, 2024

Conversation

PeterJFB
Copy link
Contributor

Description

Field was disabled when creating new email listings ;-;

Result

Screencast.from.02-19-2024.10.29.05.AM.webm

Testing

  • I have thoroughly tested my changes.
  • Attempted to use field when creating new email lists, and checked that you cannot edit with existing email listings

Resolves ABA-831

@PeterJFB PeterJFB requested a review from a team February 19, 2024 09:33
@linear Linear
Copy link

linear bot commented Feb 19, 2024

ABA-831 Fix disabled email list

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 19, 2024
@PeterJFB PeterJFB added the bug-fix Pull requests that fix a bug label Feb 19, 2024
danielyanghansen
danielyanghansen approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 💯

@danielyanghansen danielyanghansen merged commit 31bdc72 into master Feb 19, 2024
4 checks passed
@danielyanghansen danielyanghansen deleted the disabled-email-list branch February 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielyanghansen danielyanghansen danielyanghansen approved these changes

Assignees
No one assigned
Labels
bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
2 participants
@PeterJFB @danielyanghansen