Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the gradelist in ascending order #4477

Merged
merged 1 commit into from Feb 20, 2024
Merged

Conversation

magnusbrecke
Copy link
Contributor

Description

Under change classes on profile page the classes weren't presented in ascending order, more like in random order. I sorted the groups presented by id. And now they are in ascending order.

Result

Before:
Skjermbilde 2024-02-20 kl  21 36 58

After:
Skjermbilde 2024-02-20 kl  21 44 43

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • [ x] Changes look good on both light and dark theme.
  • [ x] Changes look good with different viewports (mobile, tablet, etc.).
  • [x ] Changes look good with slower Internet connections.

Testing

  • [ x] I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ABA-526

@magnusbrecke magnusbrecke added the small-fix Pull requests that fix something small label Feb 20, 2024
@magnusbrecke magnusbrecke requested review from Bestem0r and a team February 20, 2024 20:45
Copy link

linear bot commented Feb 20, 2024

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 20, 2024
Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! A good addition

Copy link
Contributor

@itsisak itsisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight 🔥

@magnusbrecke magnusbrecke merged commit 3337eb7 into master Feb 20, 2024
4 checks passed
@magnusbrecke magnusbrecke deleted the SortingGradesOrder branch February 20, 2024 20:48
@falbru
Copy link
Contributor

falbru commented Feb 20, 2024

Good job!

@ivarnakken
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
5 participants