Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed button to show more events when there are no more events to s… #4486

Merged
merged 1 commit into from Feb 28, 2024

Conversation

magnusbrecke
Copy link
Contributor

@magnusbrecke magnusbrecke commented Feb 27, 2024

Description

Fixed the frontage so that when events displayed on the front-page has reached the event limit there is no longer a button to show more events.

Result

Before:

Skjermbilde 2024-02-27 kl  20 38 48

After:

Skjermbilde 2024-02-27 kl  20 38 21

  • [x ] Changes look good on both light and dark theme.
  • [ x] Changes look good with different viewports (mobile, tablet, etc.).
  • [ x] Changes look good with slower Internet connections.

Testing

  • [ x] I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ABA-647

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 27, 2024
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has bugged me for so long! Awesome! 🏅

app/components/Header/index.tsx Outdated Show resolved Hide resolved
@ivarnakken ivarnakken added bug-fix Pull requests that fix a bug approved Pull requests that have been approved labels Feb 27, 2024
@magnusbrecke magnusbrecke self-assigned this Feb 27, 2024
Copy link

linear bot commented Feb 27, 2024

Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚀

Copy link
Contributor

@christiangryt christiangryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@norbye
Copy link
Member

norbye commented Feb 28, 2024

Just dropping in with a quick comment on the checkboxes in the description;

if you want them to show as actual checkboxes you can either

  1. Write - [x] Tada
  2. Leave them as they are in the template (- [ ] Tada) until you create your pull request. After the pull request is created, you can then click on them to check them:)

That will make them show up as this;

  • Tada

Or this

  • Tada

Instead of this;

  • [x ] Whops

@magnusbrecke magnusbrecke merged commit 02f6435 into master Feb 28, 2024
4 checks passed
@magnusbrecke magnusbrecke deleted the FixingButtonForEventsFrontpage branch February 28, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
5 participants