Move MFP to separate site #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add blacklists for events for FP and MFP * Display DayDescriptions before events have been loaded * Separate schemas for DayDescription for FP and MFP * Add sorting of DayDescriptions in Sanity
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
norbye
force-pushed
the
separate-mfp-site
branch
from
fcde0ae
to
b77f2bd
Compare
norbye
force-pushed
the
separate-mfp-site
branch
from
b77f2bd
to
ad77b7a
Compare
norbye
force-pushed
the
separate-mfp-site
branch
from
ad77b7a
to
a7dd6b5
Compare
norbye
commented
Aug 9, 2023
Comment on lines
+35
to
+53
| let firstDate: Date; | ||
| let lastDate: Date; | ||
| if (events.length === 0) { | ||
| firstDate = new Date(dayDescriptions[0].date); | ||
| lastDate = new Date(dayDescriptions[dayDescriptions.length - 1].date); | ||
| } else if (dayDescriptions.length === 0) { | ||
| firstDate = events[0].startTime; | ||
| lastDate = events[events.length - 1].startTime; | ||
| } else { | ||
| firstDate = | ||
| new Date(dayDescriptions[0].date) < events[0].startTime | ||
| ? new Date(dayDescriptions[0].date) | ||
| : events[0].startTime; | ||
| lastDate = | ||
| new Date(dayDescriptions[dayDescriptions.length - 1].date) > | ||
| events[events.length - 1].startTime | ||
| ? new Date(dayDescriptions[dayDescriptions.length - 1].date) | ||
| : events[events.length - 1].startTime; | ||
| } |
There was a problem hiding this comment.
Yes, this is trash, but I don't have the time to fix it up rn
ivarnakken
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It felt a bit misleading to have all the daydescriptions on the same site - as I do not think they share all the events from abakus.no, so I moved them over to a separate site.
Did a quick guess to see what events should and should not be in MFP, but I'll ask the MFP gang to verify later.
Heaps of duplicate code in the new materfadderperioden file, but it can be refactored later
Changes