Implement use of .svelte-kit with hot-reloading #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
PeterJFB
force-pushed
the
svelte-tsconfig
branch
5 times, most recently
from
0ee88e1
to
2496426
Compare
PeterJFB
force-pushed
the
svelte-tsconfig
branch
from
2496426
to
fc65683
Compare
|
Had a hard time working with webpack and its ts types, ended up migrating the config-file away from js, but keeping the old one since it's used by build:client-old. |
LudvigHz
reviewed
Mar 21, 2023
There was a problem hiding this comment.
What happened to the other webpack configs? Shouldn't this be a rename of the old file?
There was a problem hiding this comment.
#540 (comment)
^^^^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some svelte-types are only inferred correctly when tsconfig extends .svelte-kit/tsconfig. This has therefore been an attempt to combine the two files.
The setup to use
<script lang="ts">in svelte was also not fully configured, and required a ts-bump to be compatible with our project.The bump has also led to refactoring the code to new ts-syntax.