Move pages used by a normal user to svelte #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJFB
force-pushed
the
svelte-normaluser
branch
from
2721cc1
to
940c250
Compare
LudvigHz
reviewed
Apr 17, 2023
src/lib/stores.ts
Outdated
| message, | ||
| type, | ||
| fade, | ||
| id: Math.round(Math.random() * 10000), |
There was a problem hiding this comment.
No. Use UUID or something other that's actually predictably non-clashing.
LudvigHz
reviewed
Apr 17, 2023
Comment on lines
+17
to
+25
| // https://github.com/axe-me/vite-plugin-node/blob/main/packages/vite-plugin-node/src/server/express.ts | ||
| // production's io-server is in server.ts | ||
| adapter({ app, server, req, res }) { | ||
| if (env.NODE_ENV !== 'production' && !app.get('io')) { | ||
| const io = new Server(server.httpServer); | ||
| app.set('io', io); | ||
| } | ||
| app(req, res); | ||
| }, |
PeterJFB
force-pushed
the
svelte-normaluser
branch
from
940c250
to
0cb5e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progressFinished ™️What has been added?
/retrievealerts(should behave in the same way as the previous, with some changes to the api)socketIOServiceand the use of socket-io in development modeAdditional changes
$backendaliasTODO