Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cypress and tests for election #583

Merged
merged 1 commit into from Aug 20, 2023
Merged

Add cypress and tests for election #583

merged 1 commit into from Aug 20, 2023

Conversation

PeterJFB
Copy link
Contributor

@PeterJFB PeterJFB commented Jun 1, 2023 •
edited

It works :o

Used https://docs.cypress.io/guides/references/best-practices where it made sense

Tests for the other pages will come once this is merged :)

@PeterJFB PeterJFB force-pushed the cypress-election-tests branch 12 times, most recently from 24fcfc7 to fa26cf5 Compare June 5, 2023 21:14
@PeterJFB PeterJFB requested a review from LudvigHz June 5, 2023 21:27
@PeterJFB PeterJFB force-pushed the cypress-election-tests branch 2 times, most recently from 15cd606 to 4594ffe Compare June 5, 2023 22:09
@PeterJFB PeterJFB force-pushed the cypress-election-tests branch 3 times, most recently from 12bc8cb to f4ab29f Compare June 14, 2023 12:09
LudvigHz
LudvigHz approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! 🤩

We need to fill inn on tests, but at least this makes it possible to add more tests with ease :)

I recommend looking at the old test cases and seeing what's missing to obtains ~parity with the old E2E tests.

cypress/support/e2e.ts Show resolved Hide resolved
cypress.config.ts Show resolved Hide resolved
cypress/e2e/election.cy.ts Outdated Show resolved Hide resolved
@PeterJFB PeterJFB merged commit 24d6063 into master Aug 20, 2023
3 checks passed
@PeterJFB PeterJFB deleted the cypress-election-tests branch August 20, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

@danielyanghansen danielyanghansen Awaiting requested review from danielyanghansen

@Arashfa0301 Arashfa0301 Awaiting requested review from Arashfa0301

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterJFB @LudvigHz