You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is problematic for large request bodies that we'd like to stream and process incrementally since it holds on to the entire request body in memory and thus it can never get garbage collected.
-- aside --
I've been trying to sort out streaming in Reel (especially now that we have pipelining support). This is the API I'd like to support: a socket-like one with #read and #readpartial:
As is,
LazyRequestBody
accumulates the request body as an array of strings:https://github.com/seancribbs/webmachine-ruby/blob/master/lib/webmachine/adapters/lazy_request_body.rb#L32
This is problematic for large request bodies that we'd like to stream and process incrementally since it holds on to the entire request body in memory and thus it can never get garbage collected.
-- aside --
I've been trying to sort out streaming in Reel (especially now that we have pipelining support). This is the API I'd like to support: a socket-like one with
#read
and#readpartial
:celluloid/reel#75
What sort of method contract should we expect from a body supplied by a Webmachine adapter? I really like the "It's just a socket" approach.
The text was updated successfully, but these errors were encountered: