Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The type of sizes defined in MLResample2dOptions should be unsigned long #300

Closed
lisa0314 opened this issue Nov 29, 2022 · 1 comment · Fixed by #306
Closed

The type of sizes defined in MLResample2dOptions should be unsigned long #300

lisa0314 opened this issue Nov 29, 2022 · 1 comment · Fixed by #306
Assignees
@huningxin

Comments

@lisa0314
Copy link

As the sizes defined in MLResample2dOptions represent target sizes for each spatial dimensions of input, [size_height, size_width]. The type of sizes should align with the type of input dimensions.
@huningxin
Copy link
Contributor

Thanks @lisa0314 . This issue was raised in the Chromium CL review. I'll make a PR to fix it.

/cc @wacky6

@huningxin huningxin self-assigned this Dec 5, 2022
@huningxin huningxin mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huningxin huningxin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use unsigned long type for sizes option of resample2d huningxin/webnn
2 participants
@huningxin @lisa0314