Use unsigned long type for sizes option of resample2d #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sizes option of resample2d specifies the target sizes for each spatial dimensions of input operand. Its type should be consistent with the type of operand dimensions which is unsigned long. fix webmachinelearning#300
huningxin
requested review from
anssiko and
wchao1115
and removed request for
anssiko
|
Thanks @huningxin for the patch and @lisa0314 for reporting the issue. |
anssiko
approved these changes
Dec 5, 2022
wchao1115
approved these changes
Dec 16, 2022
|
Thanks @wchao1115, @huningxin feel free to merge. @BruceDai for wpt test alignment. |
|
Thanks for the review and approval. |
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2022
SHA: 6bffedd Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 18, 2023
This CL implements the WebNN spec changes [1] and [2] that fix the data type of attributes for MLConv2dOptions, MLPool2dOptions and MLResample2dOptions by using unsigned integers instead of signed integers. For those attributes, the negative values are not meaningful. The MLGraphBuilder, MLGraphBuilderTest and MLGraphXnnpack are updated according to this IDL change. [1]: webmachinelearning/webnn#294 [2]: webmachinelearning/webnn#306 Bug: 1273291 Change-Id: Ic7aa42ff20676b959695e66608d3254ce368c7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4164044 Reviewed-by: Jiewei Qian <qjw@chromium.org> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1093807}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sizes option of resample2d specifies the target sizes for each spatial dimensions of input operand. Its type should be consistent with the type of operand dimensions which is unsigned long.
fix #300
@wchao1115 @anssiko @wacky6, PTAL.
Preview | Diff