Change min and max values of clamp to float #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssiko
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Thanks @huningxin for the PR and @mingmingtasd for reporting the issue!
wchao1115
approved these changes
Aug 30, 2021
This was referenced Sep 7, 2021
|
With the two approvals, I'd like to merge it to unblock the development in the polyfill and samples. That would also help provide the feedbacks. Thanks. |
github-actions bot
added a commit
that referenced
this pull request
Sep 8, 2021
SHA: bd732ee Reason: push, by @huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #203
@wchao1115 @pyu10055 @anssiko , PTAL. Thanks!
cc @mingmingtasd
Preview | Diff