Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronously validate input operands/validations #605

Merged

Commits on Mar 16, 2024

  1. Synchronously validate input operands/validations

    Previously the spec had a "validate `MLOperand`" helper that (1)
    ensured the operand was from the passed `MLGraphBuilder` and (2) that
    the operand was internally consistent, and this was called during (3)
    `build()` and (4) only `concat()` among the vending methods.
    
    - (1) is needed but can be done when the `MLOperand` is created,
      giving better feedback, so (3) isn't needed.
    
    - (2) is not needed - `MLOperands` are immutable so they can't be
      created in a bad state.
    
    - (4) should be expanded to all `MLOperand` creations that take input
      `MLOperand`s.
    
    This renames the helper, ensures it is called by every `MLOperand`
    vending method that takes `MLOperand` inputs, and drops it from
    `build()` (although that will probably collide with PR webmachinelearning#603 which
    should land first). Similar validation is added for `MLActivation`s.
    
    For webmachinelearning#572
    inexorabletash committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    81a986c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    152784b View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Apply suggestions from code review

    Missed a few "if it exists" clauses
    
    Co-authored-by: Ningxin Hu <ningxin.hu@intel.com>
    inexorabletash and huningxin committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3d97b98 View commit details
    Browse the repository at this point in the history