Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: compute() explicitly rejects a promise if buffer transferring fails #639

Merged
merged 2 commits into from
Apr 16, 2024
Merged

BugFix: compute() explicitly rejects a promise if buffer transferring fails #639

merged 2 commits into from
Apr 16, 2024

Conversation

huningxin
Copy link
Contributor

@huningxin huningxin commented Apr 8, 2024 •
edited by pr-preview bot
Loading

inexorabletash
inexorabletash approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@huningxin
Copy link
Contributor Author

@fdwr , any further comments?

@fdwr
Copy link
Collaborator

fdwr commented Apr 16, 2024 •
edited
Loading

@fdwr , any further comments?

@huningxin Funny you should ask, as I'm looking right now 😉.

@fdwr fdwr merged commit c985a58 into webmachinelearning:main Apr 16, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 16, 2024
@huningxin @github-actions
BugFix: compute() explicitly rejects a promise if buffer transferri…
fb7d197 
…ng fails (#639)

SHA: c985a58
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inexorabletash inexorabletash inexorabletash approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLContext.compute() explicitly rejects promises where the sub-septs may currently throw
3 participants
@huningxin @fdwr @inexorabletash