Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove softplus() steepness option #651

Merged
merged 1 commit into from Apr 24, 2024
Merged

Remove softplus() steepness option #651

merged 1 commit into from Apr 24, 2024

Conversation

a-sully
Copy link
Contributor

@a-sully a-sully commented Apr 22, 2024 •
edited by pr-preview bot

Fixes #645

Preview | Diff

@a-sully
Copy link
Contributor Author

a-sully commented Apr 22, 2024

@fdwr PTAL?

@fdwr
Copy link
Collaborator

fdwr commented Apr 23, 2024

FYI @BruceDai since this affects conformance.
FYI @Honry, but I didn't see this impacts the ORT WebNN EP since you just pass default options anyway.

@Honry
Copy link
Contributor

Honry commented Apr 23, 2024

FYI @Honry, but I didn't see this impacts the ORT WebNN EP since you just pass default options anyway.

Correct, we didn't use steepness option in WebNN EP.

@BruceDai
Copy link
Contributor

OK, I will update WPT softplus tests to align with this change. Thanks for your kindly reminder 👍 @fdwr

huningxin
huningxin approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

fdwr
fdwr approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 No pushback from my colleagues Chai or Rafael either.

@huningxin huningxin merged commit 2d06961 into webmachinelearning:main Apr 24, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 24, 2024
@huningxin @github-actions
Merge pull request #651 from a-sully/remove-softplus-steepness
5f9ebd5 
SHA: 2d06961
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@huningxin
Copy link
Contributor

/cc @shiyi9801

@a-sully a-sully deleted the remove-softplus-steepness branch April 24, 2024 15:06
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Apr 26, 2024
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 26, 2024
@shiyi9801 @chromium-wpt-export-bot
webnn: remove softplus parameter steepness
20d7fb4 
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 26, 2024
@shiyi9801 @chromium-wpt-export-bot
webnn: remove softplus parameter steepness
9506b00 
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 28, 2024
@shiyi9801
webnn: remove softplus parameter steepness
06f475b 
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293444}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 28, 2024
@shiyi9801 @chromium-wpt-export-bot
webnn: remove softplus parameter steepness
4ca378e 
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293444}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 28, 2024
@shiyi9801 @chromium-wpt-export-bot
webnn: remove softplus parameter steepness
78709a8 
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293444}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 30, 2024
@shiyi9801 @moz-wptsync-bot
Bug 1893372 [wpt PR 45899] - webnn: remove softplus parameter steepne…
12d4356 
…ss, a=testonly

Automatic update from web-platform-tests
webnn: remove softplus parameter steepness

Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293444}

--

wpt-commits: 78709a81cc84279686438385b38572dd3ff44860
wpt-pr: 45899
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Apr 30, 2024
@shiyi9801 @moz-wptsync-bot
Bug 1893372 [wpt PR 45899] - webnn: remove softplus parameter steepne…
dab616b 
…ss, a=testonly

Automatic update from web-platform-tests
webnn: remove softplus parameter steepness

Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293444}

--

wpt-commits: 78709a81cc84279686438385b38572dd3ff44860
wpt-pr: 45899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing steepness parameter of softplus
5 participants
@a-sully @fdwr @Honry @BruceDai @huningxin