1.3.5

webmandesign · Feb 18, 2022 · e2dc282 · e2dc282
1 parent 0a45768
commit e2dc282
Show file tree

Hide file tree

Showing 25 changed files with 86 additions and 33 deletions.
diff --git a/assets/css/blocks-rtl.css b/assets/css/blocks-rtl.css
diff --git a/assets/css/blocks.css b/assets/css/blocks.css
diff --git a/assets/css/editor-style-blocks-rtl.css b/assets/css/editor-style-blocks-rtl.css
diff --git a/assets/css/editor-style-blocks.css b/assets/css/editor-style-blocks.css
diff --git a/assets/css/editor-style-classic-rtl.css b/assets/css/editor-style-classic-rtl.css
diff --git a/assets/css/editor-style-classic.css b/assets/css/editor-style-classic.css
diff --git a/assets/css/global-rtl.css b/assets/css/global-rtl.css
diff --git a/assets/css/global.css b/assets/css/global.css
diff --git a/assets/scss/blocks.scss b/assets/scss/blocks.scss
@@ -7,7 +7,7 @@
 // @copyright  WebMan Design, Oliver Juhas
 //
 // @since    1.0.0
-// @version  1.3.4
+// @version  1.3.5
 //
 
 $left: left;

diff --git a/assets/scss/blocks/_cover.scss b/assets/scss/blocks/_cover.scss
@@ -12,8 +12,19 @@
 		background-size: cover;
 	}
 
-	.has-background-dim[class*="-gradient-background"] {
-		background-color: transparent;
+	> .has-background-dim,
+	> .wp-block-cover__gradient-background {
+		margin-bottom: 0;
+
+		&.has-background-gradient {
+			background-color: transparent;
+		}
+
+		// WP 5.9 fix:
+		&::before {
+			display: none;
+		}
+
 	}
 
 	.wp-block-cover__inner-container {
@@ -63,10 +74,6 @@
 
 	}
 
-	&__gradient-background {
-		margin-bottom: 0;
-	}
-
 	&.is-style-scale-image {
 		background-repeat: no-repeat;
 		background-size: contain;

diff --git a/assets/scss/blocks/_latest-posts.scss b/assets/scss/blocks/_latest-posts.scss
@@ -117,7 +117,7 @@
 				width: calc( 100% - var(--posts_list_gap) );
 			}
 
-			&[class*=columns-] li {
+			&[class*="columns-"] li {
 				margin: calc( var(--posts_list_gap) / 2 );
 			}
 

diff --git a/assets/scss/editor-block/_accessibility.scss b/assets/scss/editor-block/_accessibility.scss
@@ -12,6 +12,7 @@
 	min-height: 40px !important;
 	padding: .25em 0 !important;
 	padding-#{$right}: 50px; // Making space for the icon.
+	margin-top: 0 !important;
 	font-size: 1em !important;
 	font-weight: 700 !important;
 	text-transform: none !important;

diff --git a/assets/scss/editor-block/blocks/__index.scss b/assets/scss/editor-block/blocks/__index.scss
@@ -15,6 +15,7 @@
 @import 'list';
 @import 'media-text';
 @import 'paragraph';
+@import 'post-title';
 @import 'preformatted';
 @import 'pullquote';
 @import 'quote';

diff --git a/assets/scss/editor-block/blocks/_post-title.scss b/assets/scss/editor-block/blocks/_post-title.scss
@@ -0,0 +1,6 @@
+/* FILE: editor-block/blocks/_post-title.scss */
+
+#{ $selector_editor_wrapper } .wp-block-post-title {
+	max-width: $max_width_content;
+	font-size: 2em;
+}
diff --git a/assets/scss/editor-style-blocks.scss b/assets/scss/editor-style-blocks.scss
@@ -9,7 +9,7 @@
 // @copyright  WebMan Design, Oliver Juhas
 //
 // @since    1.0.0
-// @version  1.3.3
+// @version  1.3.5
 //
 
 $left: left;

diff --git a/assets/scss/global.scss b/assets/scss/global.scss
@@ -7,7 +7,7 @@
 // @copyright  WebMan Design, Oliver Juhas
 //
 // @since    1.0.0
-// @version  1.3.1
+// @version  1.3.5
 //
 
 $left: left;

diff --git a/assets/scss/global/form/_base.scss b/assets/scss/global/form/_base.scss
@@ -11,7 +11,7 @@ fieldset {
 }
 
 legend {
-	margin: 0 0 ( $ratio +em );
+	margin: 0 0 ( $ratio +rem );
 	font-size: var(--typography_font_size_S_em);
 	font-weight: 700;
 	text-transform: uppercase;

diff --git a/assets/scss/global/wp/_alignment.scss b/assets/scss/global/wp/_alignment.scss
@@ -18,7 +18,7 @@
 	float: left;
 
 	&,
-	[class^=wp-block-] & {
+	[class*="wp-block-"] & {
 		margin-right: var(--typography_font_size_base); // Simulating rem unit for block editor.
 
 		@include media( map_get( $breakpoint, 'l' ) ) {
@@ -33,7 +33,7 @@
 	float: right;
 
 	&,
-	[class^=wp-block-] & {
+	[class*="wp-block-"] & {
 		margin-left: var(--typography_font_size_base); // Simulating rem unit for block editor.
 
 		@include media( map_get( $breakpoint, 'l' ) ) {

diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,25 @@
 # Michelle Changelog
 
+## 1.3.5, 20220218
+
+### Updated
+- Improving styles
+
+### Fixed
+- WordPress 5.9 bugs
+- Editor style bugs
+- Filter hook name for disabling JavaScript
+
+### File updates
+	changelog.md
+	readme.txt
+	style.css
+	assets/scss/blocks.scss
+	assets/scss/editor-style-blocks.scss
+	assets/scss/global.scss
+	includes/Assets/Factory.php
+
+
 ## 1.3.4, 20220201
 
 ### Fixed

diff --git a/includes/Assets/Editor.php b/includes/Assets/Editor.php
@@ -51,9 +51,12 @@ public static function setup_classic_editor() {
 		// Variables
 
 			/**
-			 * The `0` key item has to be empty to bypass WordPress native
-			 * RTL stylesheet enqueuing (duplicating the `0` key stylesheet
-			 * and additionally enqueuing its RTL version).
+			 * The `0` key is reserved for WordPress.
+			 * WordPress duplicates this stylesheet and makes an RTL version for it.
+			 * This is obviously not ideal when we enqueue multiple stylesheets and
+			 * want RTL for all of those. That's why we make our own RTL versions below.
+			 * @see   add_editor_style()
+			 * @link  https://developer.wordpress.org/reference/functions/add_editor_style/
 			 */
 			$styles = array( 0 => '' );
 
@@ -89,6 +92,14 @@ public static function setup_classic_editor() {
 	/**
 	 * Enqueues block editor stylesheets.
 	 *
+	 * Unfortunately, we can not really use
+	 *   add_theme_support( 'editor-styles' );
+	 *   add_editor_style( [ 'editor-styles.css', 'google-fonts.css' ] );
+	 * as that way there is no way to separate classic and block editor
+	 * stylesheets (yes, all `add_editor_style()` stylesheets are being
+	 * enqueued in both editors, plus block editor will replace certain
+	 * selectors and wrap everything in `.editor-styles-wrapper`.)
+	 *
 	 * @since    1.0.0
 	 * @version  1.3.3
 	 *

diff --git a/includes/Assets/Factory.php b/includes/Assets/Factory.php
@@ -6,7 +6,7 @@
  * @copyright  WebMan Design, Oliver Juhas
  *
  * @since    1.0.0
- * @version  1.3.0
+ * @version  1.3.5
  */
 
 namespace WebManDesign\Michelle\Assets;
@@ -328,7 +328,8 @@ public static function is_preloading_styles_disabled(): bool {
 	/**
 	 * Check whether we should disable JavaScript output.
 	 *
-	 * @since  1.3.0
+	 * @since    1.3.0
+	 * @version  1.3.5
 	 *
 	 * @return  bool
 	 */
@@ -339,11 +340,12 @@ public static function is_js_disabled(): bool {
 			/**
 			 * Filters whether to disable outputting JavaScript into HTML.
 			 *
-			 * @since  1.3.0
+			 * @since    1.3.0
+			 * @version  1.3.5
 			 *
 			 * @param  bool $disabled  By default, returns false.
 			 */
-			return (bool) apply_filters( 'michelle/assets/scripts/is_js_disabled', false );
+			return (bool) apply_filters( 'michelle/assets/is_js_disabled', false );
 
 	} // /is_js_disabled
 

diff --git a/includes/Content/Block.php b/includes/Content/Block.php
@@ -206,7 +206,7 @@ public static function register_reusable_blocks_args( array $args, string $post_
 			}
 
 
-    // Output
+		// Output
 
 			return $args;
 

diff --git a/includes/Setup/Editor.php b/includes/Setup/Editor.php
@@ -64,7 +64,12 @@ public static function after_setup_theme() {
 			add_theme_support( 'custom-spacing' );
 
 			// Experimental
-			add_theme_support( 'experimental-link-color' ); // Check `--wp--style--color--link` CSS variable.
+			/**
+			 * Check `--wp--style--color--link` CSS variable.
+			 * Does not work in WP 5.9 without `theme.json`,
+			 * which on the other hand causes so much more issues...
+			 */
+			add_theme_support( 'experimental-link-color' );
 
 	} // /after_setup_theme
 

diff --git a/readme.txt b/readme.txt
@@ -35,8 +35,8 @@ Please see `changelog.md` file.
 
 == Upgrade Notice ==
 
-= 1.3.4 =
-Fixing columns block last column margin.
+= 1.3.5 =
+Fixing bugs, improving styles.
 
 
 == Copyright ==

diff --git a/style.css b/style.css
@@ -3,7 +3,7 @@ Theme Name:    Michelle
 Theme URI:     https://www.webmandesign.eu/portfolio/michelle-wordpress-theme/
 Author:        WebMan Design
 Author URI:    https://www.webmandesign.eu/
-Version:       1.3.4
+Version:       1.3.5
 Text Domain:   michelle
 Domain Path:   /languages
 License:       GPL-3.0-or-later