Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web push dependency 3.3.2 to 3.4.4 #10

Conversation

bartbutenaers
Copy link
Collaborator

Hi @webmaxru,

This pull request updates the web-push dependency from version 3.3.2 to version 3.4.4, to solve this issue. Which is important because otherwise we create conflicts for the migrated http-request node starting from Node-RED 2.0?

Via the npm list command, you can now see that we have the required agent-base version:

image

There have been a lot of intermediate releases between web-push version 3.3.2 and 3.4.4, but almost all commits were related to updating versions of dependencies. Only following commits have added new features:

  1. commit allows a http agent to be specified in the https.request method. But since you also don't allow a proxy to be specified in the options, I don't see any reason at the moment to add the agent option.

  2. commit a timeout to be specified (in milliseconds). On timeout of the https.request, the request will be destroyed and the promise will be rejected with a meaningful error. Since that might be useful, I have added that to your configuration node:

    image

    By default (and for older nodes) this timeout is 0, which means that I don't pass it in the options.

Some remarks:

  • I have added a ^ in front of the web-push version number, to make sure minor releases of that dependency are automatically installed, as soon as users (re)install your node.
  • I have removed a duplicate code snippet in the config node.

So no major changes. Your node now still works fine in my setup...

Thanks for reviewing!!
Bart

@webmaxru webmaxru merged commit 2646383 into webmaxru:master Aug 30, 2021
@webmaxru
Copy link
Owner

Published!
Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants