Update web push dependency 3.3.2 to 3.4.4 #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @webmaxru,
This pull request updates the web-push dependency from version 3.3.2 to version 3.4.4, to solve this issue. Which is important because otherwise we create conflicts for the migrated http-request node starting from Node-RED 2.0?
Via the
npm list
command, you can now see that we have the required agent-base version:There have been a lot of intermediate releases between web-push version 3.3.2 and 3.4.4, but almost all commits were related to updating versions of dependencies. Only following commits have added new features:
commit allows a http agent to be specified in the
https.request
method. But since you also don't allow a proxy to be specified in the options, I don't see any reason at the moment to add the agent option.commit a timeout to be specified (in milliseconds). On timeout of the
https.request
, the request will be destroyed and the promise will be rejected with a meaningful error. Since that might be useful, I have added that to your configuration node:By default (and for older nodes) this timeout is 0, which means that I don't pass it in the options.
Some remarks:
^
in front of the web-push version number, to make sure minor releases of that dependency are automatically installed, as soon as users (re)install your node.So no major changes. Your node now still works fine in my setup...
Thanks for reviewing!!
Bart